Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#530 Make a_b relationships available as case roles #13916

Merged
merged 9 commits into from
Jun 12, 2019
Prev Previous commit
Next Next commit
dev/core#530 CiviCase: using label instead of name to be consistent a…
…nd commenting why
  • Loading branch information
alifrumin committed Jun 10, 2019
commit cd2c9605ce23be865f91f8a9193ec5572bb5458d
10 changes: 8 additions & 2 deletions ang/crmCaseType.js
Original file line number Diff line number Diff line change
Expand Up @@ -297,16 +297,18 @@
});
}
}
// TODO The ids below really should use names not labels see
// https://lab.civicrm.org/dev/core/issues/774
else {
result.push({
text: relType.label_b_a,
id: relType.name_a_b
id: relType.label_a_b
});

if (!isBidirectionalRelationship) {
result.push({
text: relType.label_a_b,
id: relType.name_b_a
id: relType.label_b_a
});
}
}
Expand Down Expand Up @@ -455,6 +457,10 @@
activity.default_assignee_contact = null;
};

// TODO roleName passed to addRole is a misnomer, its passed as the
// label HOWEVER it should be saved to xml as the name see
// https://lab.civicrm.org/dev/core/issues/774

/// Add a new role
$scope.addRole = function(roles, roleName) {
var names = _.pluck($scope.caseType.definition.caseRoles, 'name');
Expand Down