Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug preventing affecting cv --user on Joomla #13890

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Mar 25, 2019

See https://lab.civicrm.org/dev/joomla/issues/6

Overview

Fix problem in Joomla bootstrap that prevent the --user option of cv working.

Before

On a Joomla install: cv --user=cron ev 'print_r(JFactory::getUser())' prints the anonymous user

After

On a Joomla install: cv --user=cron ev 'print_r(JFactory::getUser())' prints the cron user (assuming you have a cron user ...)

Technical Details

CRM_Utils_System_Joomla::loadUser() saves the logged in user details in the Civi session, but did not save in the Joomla session

Comments

Only affects Joomla.

@civibot
Copy link

civibot bot commented Mar 25, 2019

(Standard links)

@civibot civibot bot added the master label Mar 25, 2019
@mattwire
Copy link
Contributor

@lcdservices A joomla one for you?

@eileenmcnaughton
Copy link
Contributor

@vingle you also know Joomla don't you

@vingle
Copy link
Contributor

vingle commented Mar 25, 2019

@vingle you also know Joomla don't you

only front-end/ui/ux really, sorry.

@aydun
Copy link
Contributor Author

aydun commented Mar 26, 2019

@agh1 - you opened the issue... any chance you can review?

@agh1
Copy link
Contributor

agh1 commented Mar 29, 2019

@aydun happy to do so. It won't be until next week, unfortunately.

@lcdservices
Copy link
Contributor

@aydun I ran through a test and confirmed the correct user account is returned.

@eileenmcnaughton
Copy link
Contributor

@aydun good to merge

@seamuslee001
Copy link
Contributor

Merging as per comments by Brian and Eileen

@seamuslee001 seamuslee001 merged commit 594eddc into civicrm:master Apr 22, 2019
@aydun
Copy link
Contributor Author

aydun commented Apr 24, 2019

@lcdservices @eileenmcnaughton @seamuslee001 - thanks for testing/approving/merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants