Mutliple activity type filters on activity tab on contact records

[eileenmcnaughton]

Overview

Change include/exclude activity type filters to be multiple select 2 widgets rather than only permitting one select - old style.

Before

After

Technical Details

This has a pre-requisite of #13855 - if reviewed separately I will rebase this.

I removed one call to validate because it was taking an already validated function - the next layer of functions were already 'array-ready' I just had to make the array get through validation & be stored correctly for sites with sticky activity filters saved (setting is under display preferences -
) & from my testing we don't need any upgrade handling. They might lose saved date filters but I think that's unlikely to be a concern since it sticks as soon as users re-filter.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[prondubuisi]

Seen @eileenmcnaughton I will check it out, thanks.

[MegaphoneJon]

Tagging @bjendres and @eileenmcnaughton because it seems like there's some convergence between what's happening in core and the https://github.com/bjendres/de.systopia.fastactivity extension. Also @artfulrobot while I'm at it to draw attention to overlap between fastactivity's features and https://github.com/artfulrobot/activitytabs/.

[eileenmcnaughton]

@MegaphoneJon right - this builds off the fact we FINALLY replaced the slow code in core with code that uses the api (I had to do some work on the api first).

As an aside another alternative to core is 'extended reportlets' - ie. any report you configure can be it's own tab on a contact

It does seem like the fastactivity extension offers some features we make sense to be in an activity - I would expect afform to eventually give that level of flexibility without an extension

[artfulrobot]

Yeah, it would be interesting to do a comparison of extended reports / activitytabs / fastactivities. If I get some time (ha!) I might have a look at that.

[colemanw]

@civicrm-builder test this please

[colemanw]

@eileenmcnaughton time for rebase

[eileenmcnaughton]

@colemanw done

[colemanw]

Tested, works perfectly.