Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID / Test ID for payment processors to list - makes setup of IPNs much easier! #13869

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

mattwire
Copy link
Contributor

Overview

We have rather long and convoluted instructions to find out the payment processor ID (and the test processor ID) when setting up IPNs and doing other work (eg. customisations on contribution pages). There doesn't really seem to be any need for this when it could easily be displayed directly on the admin UI like this:
image

Before

Complex instructions to get IDs for payment processors.

After

Much easier to get payment processor IDs!

Technical Details

Just expose the IDs on the template (and get the test ID via existing function).

Comments

@bgm @MegaphoneJon This would be a really quick review and I think you both might be interested?

@civibot
Copy link

civibot bot commented Mar 20, 2019

(Standard links)

@civibot civibot bot added the master label Mar 20, 2019
@MegaphoneJon
Copy link
Contributor

I reviewed this (both r-run and a code review) and think it's good to merge with no further changes. I think it DOES need documentation updates, but I'll create a separate Github issue for that so it's not blocking this merge. Thanks @mattwire!

@eileenmcnaughton
Copy link
Contributor

merging based on @MegaphoneJon review

@eileenmcnaughton eileenmcnaughton merged commit bfd3f0f into civicrm:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants