Expose sort_name as a dedupe-matchable field #13864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
25a8bfc to
5238367
Compare
|
test this please |
| @@ -126,7 +127,7 @@ public static function &supportedFields($requestedType) { | |||
| } | |||
| } | |||
| CRM_Utils_Hook::dupeQuery(CRM_Core_DAO::$_nullObject, 'supportedFields', $fields); | |||
| return $fields[$requestedType]; | |||
| return !empty($fields[$requestedType]) ? $fields[$requestedType] : []; | |||
There was a problem hiding this comment.
enotice fix as we are adding a test which fails on enotice
|
@eileenmcnaughton I've reviewed and tested this. Tests are passing. But the hardcoded sort_name field is a bit odd - I can see why you've done it and the explanation justifies it - but can you put that justification in as a code comment before merging? |
|
@mattwire good point - you'll get me trained on code comments yet :-) |
This opens up the option of us using a hook to do some standardisation - e.g getting rid of 'The' in the sort name & it helping with both sorting and with deduping
5238367 to
49cb372
Compare
|
@mattwire all good? |
|
Good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow sort_name to be used in dedupe rules
Before
sort_name not available
After
sort_name available, test
Technical Details
This opens up the option of us using a hook to do some standardisation - e.g getting rid of 'The'
in the sort name or perhaps trailing suffixes like 'Ltd' & it helping with both sorting and with deduping
Note that most of the fields available come from 'importable fields' - I thought about making this field 'importable' but it felt like there might be unknown consequences so I opted for just adding it in & securing it with a unit test (IMHO the test qualifies as the 'additional code improvement' required to justify it)
Comments