-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Log.php require_once statements #13842
Remove Log.php require_once statements #13842
Conversation
(Standard links)
|
Jenkins re test this please |
ping @totten seems to have passed now we have merged the composer and the removal of the original log files |
@totten given the issue we were seeing in the test earlier i have added in the Log files to the cleanup files list so that hopefully there are no clash issues on Joomla |
6a945ea
to
3377ddb
Compare
3377ddb
to
4f897b7
Compare
Agree this makes sense & we have definitely merged enough parts of this switch we are committed :-) |
Ok but how is the new |
No idea but the revert works.... |
@colemanw no because composer is including the library’s folder in its psr-0 autoloader |
Also note since this was merged I have run another ext matrix and api4 tests pass |
@seamuslee001 is there something I need to do in my local sandbox other than |
@colemanw make sure you have run composer install based on the latest master that should hopefully take care of it |
Overview
Removes now unnecessary require_once statements for Log.php files
ping @totten @eileenmcnaughton