[nfc] Attempt to improve false negatives on Logging test #13829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be significant that the one I added sleep(1) to before wasn't a fail in this one... https://test.civicrm.org/job/CiviCRM-Core-PR/25137/
|
(Standard links)
|
|
test this please |
|
different test failed - this may have helped - who knows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempt to reduce false test fails on logging
Before
no change
After
no change - maybe less false fails
Technical Details
The theory is the test box is flying so fast that there is no difference in timestamp on the 2 writes - making 'revert to previous' un-doable.
It might be significant that the one I added sleep(1) to before wasn't a fail in this one...
https://test.civicrm.org/job/CiviCRM-Core-PR/25137/
Comments