Add a class to handle test entities consistently #13814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -342,7 +342,7 @@ public function testEventAddMultipleParticipants() { | |||
| $this->clickLink("_qf_Search_refresh", "participantSearch"); | |||
|
|
|||
| //verifying the registered participants | |||
| $status = "Registered (test)"; | |||
| $status = CRM_Core_TestEntity::appendTestText("Registered"); | |||
There was a problem hiding this comment.
Hmm not translated but it's a webtest file so who cares
|
Gave it a quick spin & seems to work. Adds consistency, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test entities are handled pretty inconsistently throughout CiviCRM. From when they are displayed, the order they are displayed in, which entities they are shown on etc. I have a "sprint" topic to work on this at some point but this is a first tiny step.
Before
No consistency about how an entity shows "test".
After
Consistent function to handle the display of "test".
Technical Details
We add a new class CRM_Core_TestEntity to provide a central class for handling display of test entities.
Comments
@eileenmcnaughton related to #13779