Improve ContributionPage.validate api #13798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Because the validation data is buried deep within the form we need to load the form in order to validate - but currently the validKey check borks in post requests. Note the validity of credit card details is not checked when submitting this form, other than possibly the luhn validation. A likely use case for the validation is when the is being submitted and some handling is to be done before processing but the validity of input needs to be checked first. For example Paypal Checkout will replace the confirm button with it's own but we are able to validate before paypal launches it's modal. In this case the is post but we need validation to succeed.
3ef457a to
a1a0130
Compare
|
test this please |
|
I have to say it looks strange to see an api accessing |
|
It's awful - but there is a deeper awfulness we don't want to mess with... so I can't see another choice |
|
Merging based on mutually-agreed awfulness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This api mostly exists to support payment processors that take an action via js on the Main page during the submit process. Generally they like to abort if the page has not been correctly filled in.
The PR fixes it so the validate api can be called during POST (which would be the case with something like Paypal Checkout which calls a Promise we provide to determine whether to proceed after their button is pushed
Before
Funny key weird handling means in POST request the api cannot be called
After
POST request api validation supported, test added
Technical Details
Comments
I also marked 'id' as required