refs issue 788 fix Warning: A non-numeric value encountered in ...

[kewljuice]

Overview

Warning: A non-numeric value encountered in ...

Before

Warning: A non-numeric value encountered in ... was thrown on contribution pages & event registrations

After

Warnings are gone

Technical Details

Added extra '&' sign

Comments

https://lab.civicrm.org/dev/core/issues/788

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

Thanks for the PR @kewljuice! Unfortunately I don't think this is the right fix.

A single ampersand is a bitwise operation; two ampersands is a logical "AND". The original code is meant to do some binary number trickery to arrive at a single result. Using AND means there are two statements to evaluate. The second one is a constant and will always evaluate to TRUE.

I suspect that the correct solution is either a) to cast $self->_paymentProcessor['billing_mode'] to an int, or (better) prevent it from being stored as a string in the first place. Unfortunately PHP was designed to consider strings containing integers the same as integers in some (but not all) scenarios; this is one where it matters.

[kewljuice]

I've removed the extra '&' sign and added (int) casting.

[eileenmcnaughton]

Changes are in line with recommendations by @MegaphoneJon & I agree that's the right fix