Attempted test fix #13791
Merged
Attempted test fix #13791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
reviewed
Mar 10, 2019
This revert test has started failing frequently. It's possible the reason is performance Improvements, resulting ineffectively no change in time between the entries. I's also possible the issue is with the timestamp being used but I think that has a permitted variance
cb3a530 to
2a936fd
Compare
|
@eileenmcnaughton Do you think this change resolved this issue? If so, then go ahead and merge - it's a change in a test and won't make things any worse. |
|
@mattwire TBH I don't know - but the only way to find out is to merge & see if the false fails reduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempt to fix false negative test fail
Before
inappropriate intermittent fails
After
Maybe not?
Technical Details
This revert test has started failing frequently. It's possible the reason is performance
Improvements, resulting ineffectively no change in time between the entries.
I's also possible the issue is with the timestamp being used but I think that has
a permitted variance
Comments