dev/core#562 remove more instances of ->free() #13786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://lab.civicrm.org/dev/core/issues/562 we have been incrementally removing these as 1) we free resources on DAO->_destruct now and 2) in some edge cases freeing resources in an 'inner loop' can free outer loop resources - resulting in a hard-to-analyse bug
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup
Before
Unnecessary code / deprecated code pattern more present
After
Less unnecessary code / deprecated code pattern present
Technical Details
Per https://lab.civicrm.org/dev/core/issues/562 we have been incrementally removing these as
resources - resulting in a hard-to-analyse bug
Comments