Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break loop if address fields not found while formatting rows in Reports #13725

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Feb 28, 2019

Overview

There is a regression caught on #11660 at here. Where earlier we don't break the loop if the column name is found in the rows. But as per the previous fix, we break the loop if the value of any of the three address fields is empty.

Before

On CSV Export state_province, country or county are not translated into name.

After

On CSV Export state_province, country or county are translated into name.

Comments

ping @eileenmcnaughton @seamuslee001

@civibot civibot bot added the 5.11 label Feb 28, 2019
@civibot
Copy link

civibot bot commented Feb 28, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

makes sense - merge on pass

@eileenmcnaughton eileenmcnaughton merged commit 5270e02 into civicrm:5.11 Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants