Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate date field to datepicker on ChangeCaseType form #13701

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 25, 2019

Migrates a field to datepicker and updates some old code.

Note: this form seems somewhat broken. The "reset timeline" option doesn't appear to do anything. Neither does the date field have any effect on anything as far as I can tell. But in my testing it's no more broken after this patch than it was before.

@civibot
Copy link

civibot bot commented Feb 25, 2019

(Standard links)

@civibot civibot bot added the master label Feb 25, 2019
@colemanw
Copy link
Member Author

@civicrm-builder retest this please

@colemanw
Copy link
Member Author

@demeritcowboy does this form actually work in your client's CiviCase? I'm wondering if the breakage was recent.

@demeritcowboy
Copy link
Contributor

@colemanw It works in that install but note that by design it doesn't update any activities touched since creation, so only activities with is_auto=1 have the date changed. So maybe related to it not appearing to do anything in your case?

@eileenmcnaughton
Copy link
Contributor

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor

test this please

@demeritcowboy
Copy link
Contributor

demeritcowboy commented Feb 26, 2019

Tested at http://core-13701-6uxs5.test-1.civicrm.org:8001. Seems to work as expected. Tested with both changing the type and date and then also just the date and not type.

BEFORE:
initialstate

AFTER:
afterchangingdateandtype

@demeritcowboy
Copy link
Contributor

Note I had to log in as admin since demo didn't seem to have access to anything in the cases menu or to even see the menu. That seems separate from this change though.

@colemanw
Copy link
Member Author

Thanks for the testing @demeritcowboy
@civicrm-builder retest this please

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit 0561def into civicrm:master Feb 27, 2019
@eileenmcnaughton eileenmcnaughton deleted the changeCaseTypeDate branch February 27, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants