Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assign of currency for entityForm outside of foreach so order of fields don't matter #13696

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

mattwire
Copy link
Contributor

Overview

Per review comment on #13578 Move assign of currency for entityForm outside of foreach so order of fields don't matter

Before

Assign of currency won't work if currency is after the money fields

After

Assign of currency will work if currency is after the money fields

Technical Details

Comments

@eileenmcnaughton

@civibot
Copy link

civibot bot commented Feb 25, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Yep - this is the right follow up

@seamuslee001
Copy link
Contributor

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

test this please

2 similar comments
@eileenmcnaughton
Copy link
Contributor

test this please

@colemanw
Copy link
Member

test this please

@eileenmcnaughton
Copy link
Contributor

fail is the db not selected thing - I'm gonna merge this one since I'm pretty confident it is not affecting tests due to formy nature - if it DOES cause fails I'm sure I'll grovel

@eileenmcnaughton eileenmcnaughton merged commit 7de88d7 into civicrm:master Feb 26, 2019
@mattwire mattwire deleted the entityform_13578_fix branch March 1, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants