CRM/Logging - Fix log table exceptions #13675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that caused columns that were excluded from being considered "log-worthy" changes to be logged anyway. That happened because columns were extracted with backticks but compared to strings without backticks. To preserve compatibility with exceptions set by alterLogTables which could contain backticks, the comparison is performed against the column name with and without backticks.
|
(Standard links)
|
|
this makes sense & test cover works for me :-) Merging |
|
thanks @pfigel! I am half way through some paternity leave but I will check this out when I am back, though I see it has been merged in any case :) |
|
Just a random update from me since I went back to check on the |
|
@michaelmcandrew good to hear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug with log table exceptions not being observed.
Before
Log table exceptions defined in
CRM_Logging_Schemaor viahook_civicrm_alterLogTablesare not applied unless they're provided with backticks surrounding the column names.After
Log table exceptions are applied for columns provided with and without backticks.
Comments
Not sure if this never worked or was dependent on a certain version/fork of MySQL. This fix should work with all sane MySQL versions.