dev/core#742 Fix XML parasing by swapping & for , #13654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
OK I found a precedent here - https://github.com/eileenmcnaughton/civicrm-core/blob/63483febd50ac5d84bfca5fba2259dcb3584a7b3/CRM/Core/xml/Menu/Contact.xml#L158 so this looks good to me |
|
just noting this caused a regression #14280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes warnings about failing to parase the XML file
Before
Warnings about libxml failing to parase Activity XML
After
No warnings
Technical Details
Seems like even tho
&looks fine to parse the XML processor doesn't like it. However it seems looking at https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Menu.php#L364 there seems to have been a work around which is to use , instead of & in the xml to separate the separate path argumentsping @eileenmcnaughton @totten