EntityRef - standardize on PascalCase for entity name and fix minor bug #13631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filters objects were getting cloned instead of passed by reference, which prevented loadEntityRefFilterOptions() from saving the list for reuse.
Although entityRef fields accept either snake_case or CamelCase, let's be consistent.
|
(Standard links)
|
|
@eileenmcnaughton this is the exciting conclusion to the EntityRef trilogy. |
|
Ok this makes sense - I tested a couple of fields & they still work! I tried switching one back to lcase & it still works - good to go IMHO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just some cleanup related to EntityRef fields.
Before
EntityRef fields could theoretically accept snake_case or camelCase for the entity name, but they were not very internally consistent and might break with some compound words.
After
Standardize entityRef fields to always use the PascalCase version of the entity. Still accept other formats for legacy reasons.
Technical Details
Also includes a minor bugfix - option lists were not being cached in the entityRef filters, so ajax calls to api.getoptions were being made more often than necessary.