dev/core#720 Remove median & mode stats from contribution summary in order to improve performance

[eileenmcnaughton]

Overview

Remove mode & median from stats on contribution search summary and contribution tab on contacts as they take many times longer to render than the rest of the search. This causes a slow user experience on small to medium size sites (up to 100k contributions) and serious lags on larger sites and it was agree that the value of these stats does not warrant the pain caused

https://lab.civicrm.org/dev/core/issues/720

Before

Stats present, slow to render

After

Stats gone - page renders much faster

Technical Details

Full discussion at https://lab.civicrm.org/dev/core/issues/720 - including why the queries cannot be made fast as the annual queries on the contribution summary were

I also move the functions used to calculate the stats over to the one report which calls them. Any custom reports that still call them won't get a fatal error but the stats will not render

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw here it is - this is going to be so good for people's impressions of how fast Civi is.

[colemanw]

I guess you have to add that dumb contriTotalRight class to the only th left in this row, so it will have both contriTotalRight and contriTotalLeft classes.

[colemanw]

Yes please do this one too.

[eileenmcnaughton]

@colemanw can you test something locally - I get the best results for a contact with more than one currency by removing the tpl handling for more than one currency ie

          {if $contributionSummary.total.amount}
            <th class="contriTotalLeft right">{ts}Total{/ts} &ndash; {$contributionSummary.total.amount}</th>
            <th class="right"> &nbsp; {ts}# Completed{/ts} &ndash; {$contributionSummary.total.count}</th>
            <th class="right contriTotalRight"> &nbsp; {ts}Avg{/ts} &ndash; {$contributionSummary.total.avg}</th>
          {/if}

and NO

{if $contributionSummary.total.currencyCount gt 1}

Might be something we can just strip out?

[eileenmcnaughton]

[eileenmcnaughton]

@colmanw - I just pushed that up

[colemanw]

I guess you have to add that dumb contriTotalRight class to the last th in this row.

[eileenmcnaughton]

@colemanw do you think I should put it back or should we do something else once merged?

[colemanw]

Go ahead and add the class to the 3rd th for now. We can kill those dumb classes in a followup

[eileenmcnaughton]

OK - does that look better?

[eileenmcnaughton]

@colemanw this is all passing now

[colemanw]

• General standards
  • (r-explain) Pass
  • (r-user) Pass: Most users don't care about these stats. Those that do can find them in CiviReport.
  • (r-doc) Undecided - I think it should be documented somewhere how to get these stats from CiviReport.
  • (r-run) Pass: Works on the demo site.
• Developer standards
  • (r-tech) Pass: Less code :)
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass

[eileenmcnaughton]

Thanks @colemanw
FWIW I did some checks - loading a contact with around 20k contributions took 33 seconds before & now 9 - it was over a minute before I started on this round of changes

I search for 'all queries of financial type x in January' went from 1.5 minutes to 10 seconds - in this case I did it on our staging server which has no data for January so that extra 1 min 20 seconds was on a no-results query