Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] extract calculation of mode stat #13614

Merged
merged 1 commit into from
Feb 17, 2019
Merged

[REF] extract calculation of mode stat #13614

merged 1 commit into from
Feb 17, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code clean up preliminary to resolving performance issues

Before

Code hard to read

After

Code more readable

Technical Details

Partial of #13607 - adding 'has-tests' which were merged in #13605

Comments

@civibot
Copy link

civibot bot commented Feb 16, 2019

(Standard links)

@civibot civibot bot added the master label Feb 16, 2019
@eileenmcnaughton eileenmcnaughton mentioned this pull request Feb 16, 2019
Merged
@eileenmcnaughton eileenmcnaughton force-pushed the cont_summary_extract1 branch 4 times, most recently from 528a4bb to 29c1643 Compare February 16, 2019 21:52
@colemanw
Copy link
Member

Adding merge-on-pass based on code review and test coverage.

@eileenmcnaughton eileenmcnaughton merged commit c9f0d44 into civicrm:master Feb 17, 2019
@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton deleted the cont_summary_extract1 branch February 17, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw