Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-open campaign widget and sort by start date #13613

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 16, 2019

Overview

A followup from #13491 to make the widget act more like before.

Before

Widget requires search term before it displays any campaigns. This was done so that the filters are more discoverable, but the downside is that campaigns can't be browsed as easily.

After

The widget will auto-open and sort by start date, which should put the more current campaigns at the top.

Comments

This isn't a perfect solution but is probably the best trade-off we can get right now:

  • Sorting by end_date would be better than sorting by start_date, but the underlying api3 can't do it correctly (items with end_date of null end up at the bottom of the list rather than the top where we'd want them).
  • The filters will be harder to discover this way, but with no results people will see them.

@civibot civibot bot added the master label Feb 16, 2019
@civibot
Copy link

civibot bot commented Feb 16, 2019

(Standard links)

@colemanw
Copy link
Member Author

Ping @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor

@colemanw I'll git it a spin - it should be against the rc though I think

@colemanw colemanw changed the base branch from master to 5.11 February 16, 2019 21:50
@civibot civibot bot added the 5.11 label Feb 16, 2019
@civibot civibot bot removed the master label Feb 16, 2019
@colemanw
Copy link
Member Author

@eileenmcnaughton ok I've changed the base branch to 5.11.

@eileenmcnaughton
Copy link
Contributor

OK I just tested this & it looks good & allays my rc-testing concerns

@colemanw colemanw closed this Feb 16, 2019
@colemanw colemanw deleted the openCampaignWidget branch February 16, 2019 22:26
@colemanw colemanw restored the openCampaignWidget branch February 16, 2019 22:26
@colemanw colemanw reopened this Feb 16, 2019
@eileenmcnaughton
Copy link
Contributor

lol

@colemanw
Copy link
Member Author

Whoops deleted the branch too soon

@eileenmcnaughton eileenmcnaughton merged commit f386cb1 into civicrm:5.11 Feb 16, 2019
@eileenmcnaughton
Copy link
Contributor

some mess with tests - I think I killed the wrong one but I'm pretty sure I saw a pass in there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants