-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-open campaign widget and sort by start date #13613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Standard links)
|
Ping @eileenmcnaughton |
@colemanw I'll git it a spin - it should be against the rc though I think |
colemanw
force-pushed
the
openCampaignWidget
branch
from
February 16, 2019 21:50
27e1485
to
33ccf43
Compare
@eileenmcnaughton ok I've changed the base branch to 5.11. |
OK I just tested this & it looks good & allays my rc-testing concerns |
lol |
Whoops deleted the branch too soon |
some mess with tests - I think I killed the wrong one but I'm pretty sure I saw a pass in there... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A followup from #13491 to make the widget act more like before.
Before
Widget requires search term before it displays any campaigns. This was done so that the filters are more discoverable, but the downside is that campaigns can't be browsed as easily.
After
The widget will auto-open and sort by start date, which should put the more current campaigns at the top.
Comments
This isn't a perfect solution but is probably the best trade-off we can get right now: