[REF] extract calculation of basic stats #13608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
6a90e64 to
8ef6eb7
Compare
|
|
||
| // make sure contribution is completed - CRM-4989 | ||
| $completedWhere = $where . " AND civicrm_contribution.contribution_status_id = 1 "; |
There was a problem hiding this comment.
I've been moving this clause into the relevant queries - there just isn't enough gained by sharing bits of queries & it makes it more complicated
| @@ -5139,6 +5122,8 @@ public function summaryContribution($context = NULL) { | |||
|
|
|||
| $summary['total']['mode'] = CRM_Contribute_BAO_Contribution::computeStats('mode', $modeSQL); | |||
|
|
|||
| // make sure contribution is completed - CRM-4989 | |||
| $completedWhere = $where . " AND civicrm_contribution.contribution_status_id = 1 "; | |||
There was a problem hiding this comment.
for now - but this variable's days are numbered.....
|
Merging based on code review and passing tests. |
|
thanks @colemanw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code clean up preliminary to resolving performance issues
Before
Code hard to read
After
Code more readable
Technical Details
Partial of #13607 - adding 'has-tests' which were merged in #13605
Comments