[REF} User api rather than selector for rendering contributions on user dashboard #13584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
…et contributions to display. Note that preliminary tests for this were written & merged some time ago. Reasons for the change are 1) readability - most devs are much more comfortable with reading the api code than the selector 2) performance - the contribute selector code is deeply unperformant - mostly due to the summary function which in this case is somewhat mitigated by the limit of 12 but we are still doing something slow for no reason 3) test stability - the test for this turned out to have poor stability & hopefully this will help 4) preliminary cleanup - there are 2 existing PRs that attempt to add new buttons to this & moving towards a cleaner tpl / php layer will help with those. In addition there is a serious performance issue to address on the contribution summary function. Reducing use of that function should help with the cleanup effort
dc2113e to
8bfce65
Compare
|
Added has-test as the tests were written & merged in preparation for this (but I pushed this change out due to difficulties there - which have continued with the 'bounciness' of this test |
This was referenced Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a code cleanup on the user dashboard for readability, testing & performance reasons
Before
Selector invoked
After
api invoked - no user change
Technical Details
Note that preliminary tests for this were written & merged some time ago.
Reasons for the change are
this case is somewhat mitigated by the limit of 12 but we are still doing something slow for no reason
a cleaner tpl / php layer will help with those. In addition there is a serious performance issue to
address on the contribution summary function. Reducing use of that function should help with the cleanup effort
Comments