[REF] switch from (undeclared) class property to local variable. #13583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We either needed to declare the variable on the class & make it a local variable. Switching to a local var reflects the fact it is never accessed from outside thie function & improves readability. grepping for _userOptions returns nothing after this. I also removed an extraneous config singleton call. I can't see a strong case that either of these changes will affect the intermittent fails but ... maybe?
|
(Standard links)
|
mattwire
approved these changes
Feb 13, 2019
| $check = CRM_Core_Permission::check('access Contact Dashboard'); | ||
|
|
||
| if (!$check) { | ||
| if (!CRM_Core_Permission::check('access Contact Dashboard')) { |
|
|
||
| $session = CRM_Core_Session::singleton(); | ||
| $userID = $session->get('userID'); | ||
| $userID = CRM_Core_Session::singleton()->getLoggedInContactID(); |
|
|
||
| if (!empty($this->_userOptions['Groups'])) { | ||
| if (!empty($dashboardOptions['Groups'])) { |
There was a problem hiding this comment.
This variable is only used within this function. So ok with this if it helps set the scene for further refactoring
|
thanks @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup
Before
undeclared class property used, extraneous config call
After
local var used, extraneous call removed
Technical Details
We either needed to declare the variable on the class & make it a local variable. Switching
to a local var reflects the fact it is never accessed from outside thie function & improves readability.
grepping for _userOptions returns nothing after this.
I also removed an extraneous config singleton call. I can't see a strong case that either of
these changes will affect the intermittent fails but ... maybe?
Comments
@seamuslee001 @mattwire either of you OK to check this - should be pretty simple as it's just preliminary to my next step (using the api to get the contribution rows rather than Selector object - in order to simplify some performance fixes & hopefully deal to the intermittent test fail)