Contribution/ContributionRecur metadata updates for EntityForm #13579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Feb 13, 2019
| @@ -369,7 +372,7 @@ public static function &fields() { | |||
| 'start_date' => [ | |||
| 'name' => 'start_date', | |||
| 'type' => CRM_Utils_Type::T_DATE + CRM_Utils_Type::T_TIME, | |||
| 'title' => ts('Recurring Contribution Started Date'), | |||
| 'title' => ts('Start Date'), | |||
There was a problem hiding this comment.
The reason for these ridiculously long names may have been to disambiguate fields on the import/export forms where they are all shown in a flat list.
|
@mattwire the title changes do give me pause - TBH I've been ignoring the slight weirdness of leaving the long ones in place & just using the overly long ones on the forms. I guess the places I can think of where it might be relevant to disambiguate are import, export & views - can you think of any others @colemanw ? |
|
I checked views & there seems to be hard-coded metadata. import & export don't show these fields - I'm happy to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates to ContributionRecur metadata so that we can use it to autogenerate forms.
Before
Less useable metadata
After
More useable metadata
Technical Details
Tweaks to labels, html elements so they can be used automatically on a form.
Comments
ping @eileenmcnaughton as I think you understand the reasons behind this best :-)