Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Minor readability cleanup #13562

Merged
merged 1 commit into from
Feb 13, 2019
Merged

[REF] Minor readability cleanup #13562

merged 1 commit into from
Feb 13, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor readability cleanup

Before

use of extract makes it hard to see where variables are being defined

After

extract removed, simpler & more thorough cleanup fn

Technical Details

Comments

@civibot civibot bot added the master label Feb 11, 2019
@civibot
Copy link

civibot bot commented Feb 11, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 are you OK to give this merge-on-pass - only affects a test

@seamuslee001
Copy link
Contributor

Added merge on pass as Jenkins is the only real checker here

@eileenmcnaughton eileenmcnaughton merged commit b2532c3 into civicrm:master Feb 13, 2019
@eileenmcnaughton eileenmcnaughton deleted the payment_test branch February 13, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001