Fix trailing ampersands when empty array passed as query param #13461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes this issue on Lab.
Additionally removes the incorrect parsing of any arrays passed as the
$query
param toCRM_Utils_System_WordPress::url()
. The$query
param should never be an array because this is handled byCRM_Utils_System::url()
beforehand andCRM_Utils_System_WordPress::url()
should never be called directly.Before
Calling
CRM_Utils_System::url()
with params such as:results in a URL of the form:
After
URLs no longer have the trailing ampersand: