Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#647) Fix up Test Class names and file names to ensure all t… #13415

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

seamuslee001
Copy link
Contributor

…est classes are run by Jenkins

Overview

This fixes up some test Classes and one file name to get Jenkins / phpunit to find them and run them

Before

Test classes skipped

After

Test classes not skipped

@civibot
Copy link

civibot bot commented Jan 7, 2019

(Standard links)

@civibot civibot bot added the master label Jan 7, 2019
@seamuslee001
Copy link
Contributor Author

ping @eileenmcnaughton @totten

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 I'm giving this a very optimistic merge-on-pass. Previous finds of these have also found that the test isn't actually passing - for various reasons. Anyway cross figures there are no worms in this can

@seamuslee001
Copy link
Contributor Author

I like optimism

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton i have pulled the contact selector test out into its own PR #13416

@seamuslee001
Copy link
Contributor Author

Merging as per the tag

@seamuslee001 seamuslee001 merged commit 3a22ade into civicrm:master Jan 8, 2019
@seamuslee001 seamuslee001 deleted the nfc_test_file_fixes branch January 8, 2019 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants