dev/core#337 Add in upgrade script to set search by range to be false… #13384
Conversation
… for Fields of money, float, int with widget types radio and select which were how they were effectively implementeted originally
|
(Standard links)
|
|
Note that I also merged the related PR - #13314 & a release notes update will be needed to cover them |
|
Merging as per the tag |
| @@ -61,7 +61,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) { | |||
| 2 => ts('Email on Hold'), | |||
| ); | |||
| $postUpgradeMessage .= '<p>' . ts('If the setting "%1" is enabled, you should update any smart groups based on the "%2" field.', $args) . '</p>' . | |||
| '<p>' . ts('If you were previously on version 5.8 and altered the WYSIWYG editor setting, you should visit the <a %1>Display Preferences</a> page and re-save the WYSIWYG editor setting.', array(1 => 'href="' . CRM_Utils_System::url('civicrm/admin/setting/preferences/display', 'reset=1') . '"')) . '</p>'; | |||
| '<p>' . ts('If you were previously on version 5.8 and altered the WYSIWYG editor setting, you should visit the <a %1>Display Preferences</a> page and re-save the WYSIWYG editor setting.', array(1 => 'href="' . CRM_Utils_System::url('civicrm/admin/setting/preferences/display', 'reset=1') . '"')) . '</p><p>' . ts('If you have any custom fields of type Money, Int or Float, The search by range checkbox has been unchecked for these fields. If you wish to search by range on those fields you must re-set the checkbox') . '</p>'; | |||
There was a problem hiding this comment.
If you have any custom fields of type Money, Int or Float, The search by range checkbox has been unchecked for these fields. If you wish to search by range on those fields you must re-set the checkbox.
@seamuslee001 When I first read this text, I was pretty alarmed, so then I read more of the the background discussion -- and maybe it was false alarm and just a wording issue? Restating the situation to check my comprehension: This does not apply to all Money|Int|Float fields -- rather, it specifically applies to Radio|Select. To understand why this was done, it helps to consider the visual from the "New Custom Field" screen:
In older versions (<=5.8), for fields with (Money|Int|Float)+(Radio|Select), you would see the first option but not the second. In v5.9, you would see both. Consequently:
- Pre-existing fields (from <=5.8) don't have a sensible value of
is_search_range. The option wasn't displayed in the UI before. so there was no specific intent. - The behavior in old-versions depends on the specific old-version -- either it was crashy before, or it had a select/radio-type UX (not a search-range UX).
- Without the patch, pre-existing fields (from <=5.8) effectively change their behavior (becoming a search-range UX).
- With the patch, pre-existing fields (from <=5.8) effectively keep their behavior (select/radio-type UX).
- If you were using an interim version (5.9-alpha or 5.9-beta?) , then the upgrade script may override the policy -- these are the people who need to update the setting.
(NOTE: Italics indicate some edited text.)
How about this language:
CiviCRM v5.9+ adds a new search preference for certain custom-fields ("Money", "Integer", or "Float" data displayed as "Select" or "Radio" fields). For continuity, any old fields have been set to continue the old user-experience. However, you may want to review these settings. (You should especially review if this site used v5.9-alpha or v5.9-beta.)
There was a problem hiding this comment.
sure happy with that @totten
… for Fields of money, float, int with widget types radio and select which were how they were effectively implemented originally
Overview
This adds in an upgrade sql step and also a post upgrade message as per @eileenmcnaughton 's comments here #13314
ping @eileenmcnaughton @totten @colemanw