Make submitOnce() button js into a button parameter

[mattwire]

Overview

Multiple different forms implement the same javascript line to add a submitOnce() button handler to the submit buttons. CRM_Core_Form::addDefaultButtons() has a parameter to add this but it's not really very generic as most forms call CRM_Core_Form::addButtons().

This PR adds a parameter submitOnce to the button create array which will automatically add that handler for any button that sets that to TRUE. The parameter is added initially for the "Open Case" form submit buttons.

Before

Every time you want a "submit only once" button you have to add the same line of javascript to the button array parameters.

After

Every time you want a "submit only once" button just add the parameter submitOnce = TRUE.

Technical Details

Comments

Standardise and simplify the way we add form buttons.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw can you check this one?

[mattwire]

@colemanw Ping :-) Are you able to take a look?

[colemanw]

Just tested this. Makes sense, and more important, it works :)

[demeritcowboy]

Hi, this seems to break the Save and New button. It saves but doesn't present the new form.
https://lab.civicrm.org/dev/core/issues/904