Fix period_type, duration_unit, duration_frequency to be required on membership type form

[eileenmcnaughton]

Overview

Fixes a regression where some required fields are not showing as required

Before

Duration unit, frequency & plan type (period_type) not showing as required

After

fields required

Technical Details

@mattwire this is from changes to the membership type form - I feel like we should get this merged for the rc (@monishdeb @seamuslee001 maybe one of you can merge).

I also think that MembershipType.xml should have these fields marked as required - I am always a bit hesitation to make changes like that in an update script in case a site has already some nulls & it causes pain. However, changing the schema only would change the DAO / new installs

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass fixes issue where required fields weren't marked as such
  • (r-doc) Pass
  • (r-run) Pass confirmed the fields now show required where they are meant to be
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass

[seamuslee001]

Merging (don't need merge on pass as test build finished)