dev/mail#23: Bounce processing doesn't catch pattern 'user doesn't exist'

[monishdeb]

Overview

Some email providers throw the bounce pattern "user doesn't exist", which is not found, and therefore results in bounce_type "syntax". However, this bounce pattern should result in immediately put the email addresses to on-hold.

Before

Does not detect bounce pattern 'user doesn't exist ' as invalid bounce type.

After

Detect bounce pattern 'user doesn't exist ' as invalid bounce type.

Comments

ping @lcdservices @eileenmcnaughton @seamuslee001

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This looks good to me i used https://regex101.com/ to test the regex and it seems to be able to capture the 3 versions user unknown user does not exist user doesn't exist

[seamuslee001]

@monishdeb you need to escape \ the ' in doesn't

[monishdeb]

Thanks @seamuslee001 for pointing that out.

(how could I missed that sigh)

[seamuslee001]

I'm going to add merge on pass on this given i have tested the regex using a tester. Jenkins will tell us if the upgrade goes wrong at all and the change looks correct to me

[monishdeb]

Thanks @seamuslee001

FYI here's how I tested my change earlier:

    $p = 'user doesn\'t exist';
    CRM_Core_Error::debug_var('a', CRM_Mailing_BAO_BouncePattern::match($p));

which prints

$p = Array(
'bounce_type_id' => 6,
'bouce_reason' => 'user doesn\'t exist',
)

Earlier w/o patch I was getting:

$p = Array(
'bounce_type_id' => NULL,
'bouce_reason' => 'user doesn\'t exist',
)

[seamuslee001]

Merging as per the tag