dev/core/485 Website type should be required as other type values are

[elisseck]

Overview

Strange behavior possible as described in https://lab.civicrm.org/dev/core/issues/485.

A user could save a website record without a 'website type' (applies to any contact type, not just organization as in the ticket). Storing this value without a type, which should be required, causes data to be seemingly mysteriously deleted.

Before

User is able to click the (x) and save a website record with no type

After

User can no longer click an (x) and must instead choose a website type, even if they create their own option value labelled "none", they must choose a type.

Technical Details

Adding the 'placeholder' => NULL option here is what looks standard when looking at the code for IM, Phone, Email, etc. They all require a type to be saved, so website should, too... or we'll run into trouble.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 @colemanw @mattwire @lcdservices do you have an opinion on this - it is a behaviour change but the previous behaviour was a bit broken....I guess what might happen is people have lots of website in their db without type & every time they go to edit them they get forced to add type....

Having said that - I would assume that without type you can't export them etc so it is kinda invalid

[lcdservices]

I agree that makes sense and is consistent with the other data objects.

[yashodha]

works fine and is consistent with others.
@lcdservices @eileenmcnaughton shall we merge this?

[eileenmcnaughton]

Thanks for the ping @yashodha - looks like you and @lcdservices have weighed in in favour of merging this so lets do it!