dev/core/482 standardize contact edit form delete block behavior

[elisseck]

Overview

When adding a new contact via the "New Individual", "New Organization" etc forms, or editing a contact, the website blocks allow a user to delete a block even if it's the only one left. Afterwards, the user is not able to re-create a website block. This is non-standard for this form i.e. Phone Number, Email, IM do not let a user delete a block if it's the only one left.

Relevant issue: https://lab.civicrm.org/dev/core/issues/482

Before

Users can delete the last website block, breaking their ability to add a website.

After

Users are not given the option to delete the last website block, which is the standard behavior for this form.

Technical Details

The js to create a new block relies on an existing block of that type to copy. If statement added is present in the templates for phone, IM, email blocks but was missing in the website block template.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[elisseck]

While looking at a different, possibly related issue I realized that the website inline form has a different template with the same issue. My second commit should resolve that bit as well.

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[monishdeb]

This change makes sense, it is as per how we are redendering delete icon for other fields, as in:

templates//CRM/Contact/Form/Edit/IM.tpl:44:    {if $blockId gt 1}
<a class="crm-delete-inline crm-hover-button" href="#" title="{ts}Delete IM{/ts}"><span class="icon delete-icon"></span></a>
templates//CRM/Contact/Form/Edit/OpenID.tpl:42:    {if $blockId gt 1}
templates//CRM/Contact/Form/Edit/Phone.tpl:51:  {if $blockId gt 1}

Checked in my local works for me :