(dev/core#217) Search.setting.php - Fix mismatched metadata #13168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting `prevNextBackend` was introduced in PR civicrm#12665. The PR was originally written for an earlier version (circa 5.6) and eventually merged in a later version (circa 5.9). The metadata should match the version-number of the actual release.
|
(Standard links)
|
|
Adding Merge on pass as sensible and straight forward, this is also very NFC |
|
Merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The setting
prevNextBackendwas introduced in PR #12665. The PR was originally written for an earlier version (circa 5.6) and eventually merged in a later version (circa 5.9). The metadata should match the version-number of the actual release.Before
prevNextBackendsays it was added in 5.6, which is wrong.After
prevNextBackendsays it was added in 5.9, which is right.