dev/core#536 Remove duplicate call to contribution summary

[eileenmcnaughton]

Overview

As part of addressing performance issues on the contribution summary tab this first step simply reduces the number of expensive but redundant queries that run

Before

Time spent on running some sql queries twice

After

The 6 queries in question only run once. At volume these are slow queries so this saves around 20
seconds to load a contact with a lot of contributions on a very large database. Even very small databases will get some gain as there are just less queries

We still see the summary

And here

Technical Details

This is an expensive call (we get it at over 10 seconds for high
giving contacts in a large database) and it is quite simply called twice.

Removing these few lines knock out several expensive queries but I have checked
contribution tab, user dashboard, contribution search and advanced search displayed
as contributions and can find no instances where less info is shown.

(in the case of advanced search displayed as contributions it doesn't show before or
after)

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@pradpnayak @monishdeb @kcristiano @jitendrapurohit I will be interested if any of you can find anywhere adversely affected by this change

[jitendrapurohit]

Tested this and verified it on different search forms, contribution dashboard, user dashboard and contact summary pages. The behaviour looks same before and after this change. +1 from my testing results 👍

[colemanw]

Just to make sure I understand this @eileenmcnaughton - I grepped for a while to try to find where the smarty variable contributionSummary was still being assigned after removing these lines. I see where it is assigned in this file on line 157 but couldn't for the life of me see where that session variable was coming from... until I found this:

civicrm-core/CRM/Core/Selector/Controller.php

Line 372 in fee1419

$this->_store->set("{$this->_prefix}summary", $summary);

So it's automatically being run from the controller... is that correct?

[eileenmcnaughton]

@colemanw yes - it's being run - twice each time it seems!

It's actually an expensive query but my thinking is that if we could call a DIFFERENT function for a singe contact vs a search then we could actually get an optimised query for the single contact. In testing I can get each of the queries in this function from 6 seconds to 6 hundreths of a second with an index hint

[eileenmcnaughton]

As a follow up I've been able to do some testing and this reduces the time to load the contribution tab for our slowest contact from 58-60 seconds to 30 - which is perhaps not a surprising result since we halved the slow queries