Export code cleanup - only construct one metadata array with all types of metadata #13126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
847abb8 to
39d15be
Compare
39d15be to
ae5d4ca
Compare
mattwire
approved these changes
Nov 21, 2018
There was a problem hiding this comment.
I've tested this with a contact export, contribution export and membership export. All seems to work as before.
As an aside I noticed that some membership columns were showing field names instead of labels: max_related, membership_recur_id, member_is_override, member_auto_renew but that's independent of this PR as it was happening before/after.
| /** | ||
| * @var array | ||
| */ | ||
| protected $outputSpecification = []; |
There was a problem hiding this comment.
A bit picky, but could we have a basic comment here explaining what this array is for?
There was a problem hiding this comment.
yeah - I'll add in a follow up
|
thanks @mattwire merging based on the above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Further export code cleanup
Before
Code more brittle
After
Code more maintainable
Technical Details
This moves away from the construction of multiple related arrays that need to be kept in sync to a single array holding the data for the various arrays
Comments
@mattwire this is a little bit harder to read code-wise than some of the other chunks but it is very heavily tested
Follow on currently in https://github.com/civicrm/civicrm-core/compare/master...eileenmcnaughton:export_more_im?expand=1