dev/core#528 - Advanced Search -> Contribution Tab and Contribution D…

[jitendrapurohit]

…ashboard returns a fatal error

Overview

Fix network error on advanced search and fatal error on civicontribute dashboard.

Before

On Dmaster
https://dmaster.demo.civicrm.org/civicrm/contact/search/advanced?reset=1 -> Expanding the contribution div section displays a network error

Similarly, Contribution Dashboard returns a fatal error - https://dmaster.demo.civicrm.org/civicrm/contribute?reset=1

After

Fixed.

Technical Details

cancel_reason input field was replaced with the latest addField function which expects an _action to be loaded on the page. We can fix this by simply ignoring to load the search form on dashboard page by inserting an if check at this point. But as we load the browse action on civicase, this PR follows the same rule.

Comments

This error is not present in 5.8rc released version.

Gitlab - https://lab.civicrm.org/dev/core/issues/528

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

thanks @jitendrapurohit - and thanks for checking it is not in the 5.8rc

[monishdeb]

Merging as per label.