Fix handling of advmutltiselect (on localization form). Handle casing issues #13062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n notice rather than hard-fail for incorrect case for html type. We have clarified the correct syntax (it was haphazard) an updated the docs. This ALSO fixes fails on localisation form
|
(Standard links)
|
|
Confirmed this is an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per #13048 this makes the settings form still accept mis-cased settings - but not in a noise-free way and resolves the loss of support for advmultiselect
Before
Localization form a bit borked in unreleased code. Form borked for Mosaico admin settings & others
After
Forms fixed. Mosaico settings will show deprecation notices but these will not affect live sites (I will do a PR to fix their form though)
Technical Details
ALso see civicrm/civicrm-dev-docs#555
Comments