Convert final settings on the Display form #13040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
3ae0e33 to
719eda4
Compare
|
test this please |
|
I have reviewed the code and run this PR locally. Merge on pass |
|
Added merge on pass as per Matt's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Convert display form to be fully metadata based
Before
mix of hard-coding & metadata
After
Hard-coding only affects the very-non-standard 'invoicing' setting impact on the form - this should be handled better but is out of scope for now
Technical Details
Ties in with other recent preferences forms changes
Comments
@mattwire @seamuslee001