Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strtolower fix 'name' #13035

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove a further instance of performance-hurting, bug creating lower case comparison - in this case in a piece of code that is not hit by tests & which I could not hit using the UI. I added a deprecation notice to surface anywhere it is actually used

Before

strtolower + LOWER used

After

mysql handling used.

Technical Details

Per #12494

Comments

@civibot
Copy link

civibot bot commented Oct 29, 2018

(Standard links)

@civibot civibot bot added the master label Oct 29, 2018
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

This is keeping in with our understanding that removing both LOWER and the strtolower improves performance and doesn't cause regressions. Whilst this is not covered by the test coverage i think its safe to merge as we have done this in other areas with no dramas and also there is the warning that is given off if there is an issue

@seamuslee001 seamuslee001 merged commit 7290ca0 into civicrm:master Nov 2, 2018
@seamuslee001 seamuslee001 deleted the strtolower_name branch November 2, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants