Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#481 Ensure that Bulk Mailings is a checkbox rather than radi… #13019

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

seamuslee001
Copy link
Contributor

…o to allow for users even when only 1 bulk mailing setting to unset bulk mailing

Overview

Allow for users to unset bulk mailing from an email

Before

Bulk Mailing was a radio in non multiple bulk email set

After

Bulk Mailing is now a checkbox so users can unset the Bulk Email setting

ping @pradpnayak @eileenmcnaughton

…o to allow for users even when only 1 bulk mailing setting to unset bulk mailing

Fix UI handling when in multiple bulk email mode
@civibot
Copy link

civibot bot commented Oct 27, 2018

(Standard links)

@civibot civibot bot added the master label Oct 27, 2018
@alifrumin
Copy link
Contributor

I tested this and think it is ready to be merged.

How I tested:

I logged into a 5.6 test site and was able to replicate that the Bulk Mailing field on an email for a New Contact is displayed as a radio button and there is no way to un-select it once it is selected see screenshot below:

Bulk Mailing field as radio that once checked cannot easily be unchecked

I then logged into the test site created by Jenkins for this pr. With this pr, the Bulk Mailing field on an email for a New Contact is displayed as a checkbox that can be checked and unchecked:

bulk mailing field as a checkbox that can be checked and unchecked

@eileenmcnaughton
Copy link
Contributor

I'm going to merge this as @pradpnayak logged it, @seamuslee001 worked on it & @alifrumin reviewed it - that means 3 experienced people have considered whether this is a good change to make & 2 have checked it works - for a UI element I think that is appropriate

@eileenmcnaughton eileenmcnaughton merged commit db0e416 into civicrm:master Oct 29, 2018
@eileenmcnaughton eileenmcnaughton deleted the lab_core_481 branch October 29, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants