dev/core#474 - Show missing log table warning only if logging is enabled

[jitendrapurohit]

Overview

Fix missing log table warning on the status page.

Before

Missing Log table warning is shown even if logging is disabled in the following scenario -

• Logging is enabled on the site which generates a list of log tables in the database.
• User now disables the logging functionality on the site which now stops generating any more log tables.
• User create a custom set on the site which creates a new table in the database.
• The system status page notices a missing log table for the above and displays a warning.

The last step should also check if the logging is enabled on the site even if it is able to find some core log tables already present in the db.

After

Missing log table warning only shown if logging is enabled.

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/474

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

why not just CRM_Core_Config::singleton()->logging ? @eileenmcnaughton

[eileenmcnaughton]

@seamuslee001 I agree that would be better - but I see your CRM_Core_Config::singleton()->logging and raise you a \Civi::setings()->get('logging');

[seamuslee001]

yeh setting is probably better / more straight forward

[eileenmcnaughton]

@seamuslee001 but you must be pre-coffee ATM - can we trust anything you say right now?

[seamuslee001]

a bit yes but it also your suggestion you know

[eileenmcnaughton]

We should definitely do this - @jitendrapurohit can you tweak the line to one of the other options just as part of discouraging the pattern of defining $config & then using it. My pref is the setting version....

[jitendrapurohit]

Done 👍

[seamuslee001]

Merging as per the tag