Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for repetition_start_date #12997

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 24, 2018

Overview

Fix default not loading for start date on event repeat pane. It should default to the current event start date but due to date mishandling this is not happening

Before

screenshot 2018-10-24 17 22 47

After

screenshot 2018-10-24 17 31 24

Technical Details

I think this is a regression from #12746 hence I put it against the rc which contains that fix. It's pretty trivial so should be rc-safe

Comments

@colemanw @mattwire you were both involved in the earlier one. Note there might be other affected places because the original PR focussed on recurring entities from the activity screen but I'm not sure what other screens support it. Also, possibly CiviVolunteer?

@civibot
Copy link

civibot bot commented Oct 24, 2018

(Standard links)

@civibot civibot bot added the 5.7 label Oct 24, 2018
@colemanw
Copy link
Member

This fix is consistent with all the other work that's been done in this area, makes sense and tests pass.

@colemanw colemanw merged commit 7a790ce into civicrm:5.7 Oct 24, 2018
@eileenmcnaughton eileenmcnaughton deleted the 5.7 branch October 24, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants