Remove instances of LOWER casing searches from sort_name, display_name #12987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improve performance and reliability of searches involving sort_name & display_name (under some circumstances) by relying on mysql to handle case.
Before
We actively convert the string to use lower case in php and then use mysql LOWER for the comparison
After
We let mysql do what it does well. Test added
Technical Details
Per #12494 mysql handles lcase.
Adding LOWER to mysql queries makes them slower. lowercasing php strings
breaks under some character sets with some server configs. Less is more
Comments
@seamuslee001 @monishdeb @colemanw I think we should push through on these since we have been chipping away for a few months after this discussion #12494 with no fallout