dev/core#461 - Duplicate Message template is generated when it is sav…

[jitendrapurohit]

…ed through schedule reminder form

Overview

Duplicate Message template is generated when it is saved via schedule reminder form

Before

Instead of saving a new msg template from the sched reminder form, multiple duplicates are created on single save. See steps to reproduce at https://lab.civicrm.org/dev/core/issues/461.

Also replicated on https://dmaster.demo.civicrm.org/civicrm/admin/messageTemplates?reset=1

After

Single template is saved.

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/461

[homotechsual]

(CiviCRM Review Template DEL-1.1)

• Explain (r-explain)
  • PASS : The goal/problem/solution have been adequately explained in the PR.
• Test results (r-test)
  • UNREVIEWED
  • COMMENTS: Test bot is not running due to GH service issues.
• Code quality (r-code)
  • PASS: The functionality, purpose, and style of the code seems clear+sensible.
• Documentation (r-doc)
  • PASS: The changes do not require documentation.
• Maintainability (r-maint)
  • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
• Run it (r-run)
  • PASS: Reproduced issue on CiviBuild Dmaster site - rebuilt site with PR - cannot reproduce issue with the PR applied.
• User impact (r-user)
  • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
• Technical impact (r-tech)
  • PASS: The change preserves compatibility with existing callers/code/downstream.

[seamuslee001]

Jenkins test this please

[alifrumin]

I was able to replicate this bug on https://dmaster.demo.civicrm.org/civicrm/admin/messageTemplates?reset=1 by following the directions outlined on https://lab.civicrm.org/dev/core/issues/461

Then I tested on the jenkins build.

This pr fixes the bug.

This is ready to be merged from my perspective.

[seamuslee001]

Merging as per Alice and Mikey's testing