Convert relationship form to datepicker #12972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Oct 19, 2018
CRM/Contact/Form/Relationship.php
Outdated
| } | ||
| if (!empty($this->_values['end_date'])) { | ||
| list($defaults['end_date']) = CRM_Utils_Date::setDateDefaults($this->_values['end_date']); | ||
| $defaults['end_date'] = $this->_values['end_date']; | ||
| } |
There was a problem hiding this comment.
I think these statements are now redundant; you are basically assigning the same value that is already there.
There was a problem hiding this comment.
I've just checked and they are still required, _values is not passed to $defaults without assignment here. However, I've cleaned it up so we're now using CRM_Utils_Array::value() instead of a 3 line if statement.
f00528a to
57bdb9e
Compare
57bdb9e to
425d606
Compare
|
I tested creating a new relationship, editing the relationship & deleting it & date fields worked. I also confirmed I could set end date before start - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Convert the start_date/end_date elements on the relationship edit form to use datepicker.
Before
Uses deprecated jcalendar
After
Uses datepicker
Technical Details
Comments
@colemanw Are you able to review this one?