Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed redirect URLs #12969

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Conversation

christianwach
Copy link
Member

@christianwach christianwach commented Oct 19, 2018

Overview

Fixes Issue 460. Please refer to that for details.

Prevents CRM_Core_QuickForm_Action_Jump::perform() from constructing invalid URLs.

Before

Can produce URLs like this:

https://civicrm.latest/civicrm/event/register/?&_qf_ThankYou_display=true&qfKey=<some-key>

After

Will build URL like this:

https://civicrm.latest/civicrm/event/register/?_qf_ThankYou_display=true&qfKey=<some-key>

@civibot
Copy link

civibot bot commented Oct 19, 2018

(Standard links)

@civibot civibot bot added the master label Oct 19, 2018
@christianwach
Copy link
Member Author

Related PR: #11708

@kcristiano
Copy link
Member

Tested and PR works as described. Further comments:

https://lab.civicrm.org/dev/core/issues/460#note_10049

@kcristiano
Copy link
Member

Tested on WP 4.9.8 and CiviCRM master as well as Drupal 7 and CiviCRM Master

The code here fixes the malformed URL and is an improvement. This PR is merge ready.

@seamuslee001
Copy link
Contributor

Adding merge on pass based on @kcristiano testing

@seamuslee001
Copy link
Contributor

Merging as per Kevin's testing

@seamuslee001 seamuslee001 merged commit a1d4f74 into civicrm:master Oct 31, 2018
@christianwach christianwach deleted the issue-460 branch December 5, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants