Fix notices on Membership Settings form. #12960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Membership settings form has some enotices off the back of work on the display form. This fixes those & makes it a 'pure' form in that it relies fully on the metadata
|
(Standard links)
|
|
The changes look and I have tested this on current version Before: After: Good to Merge! |
|
thanks @pradpnayak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix some e-notices appearing on membership settings form (in master only, not in released versions), simplify code
Before
After
Technical Details
There has been work done to sync up the 'settings' forms & 'preferences' forms which differ for historical reasons only & now have a shared settingstrait to migrate to. His has caused some warnings & notices which I am fixing
Comments
@mattwire