[dev/core#457] Add $ids to hook_civicrm_export

[scardinius]

Overview

Because of GDPR rules we have to save information that some data were exported.

Before

Current hook https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_export/ is not enough because it returns data without id columns. It's hard to implement any sophisticated feature without id of objects.

After

Existing export hook is extended

CRM_Utils_Hook::export($exportTempTable, $headerRows, $sqlColumns, $exportMode, $componentTable, $ids);

Technical Details

You can find example here veda-consulting-company/uk.co.vedaconsulting.gdpr#157

Comments

no comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[pradpnayak]

@scardinius Doesn't the $exportTempTable table have id of the component?

[scardinius]

@pradpnayak it depends on type of exporting object. As I remember only temporary table for contacts contains id

[pradpnayak]

Probably with different column name? eg activity_id, contribution_id.

@scardinius I think we should extend export code to store id for component in $exportTempTable table so that it would be useful for other need if some wants to play around with it like not to export certain rows using component id etc using hook_civicrm_export.

Thoughts?

[colemanw]

I tend to agree that the existing hook should be improved instead of adding a redundant one.

[scardinius]

Hi, thanks for your suggestions. I've just move these two new variables into export hook

[colemanw]

Makes sense to me 👍

[colemanw]

@scardinius it would be helpful if you could squash the commits from this PR into one so we can have a nice commit history in master.

[scardinius]

@colemanw you're right, I'll squash them

[scardinius]

@colemanw I've just squashed the commits

[colemanw]

Verified that the variables are always defined and that this function is only called in that one place, so this is safe to merge.

[colemanw]

@scardinius please update https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_export/

[scardinius]

@colemanw sure, I will

[scardinius]

@colemanw doc updated civicrm/civicrm-dev-docs#560